Basically i felt like they had a great story in their somewhere but they kind of missed the mark.
Yeah, I agree. This was the best X-Men movie in years, even though it wasn't really an X-Men movie.
Firstly, why in these movies set dystopian future is "escaping across the border" always seen as a brilliant plan? In a truly dystopian future, Canada and Mexico are going to be as shitty and corrupt as the USA, if not moreso. Do the mutants think it's going to be nothing but poutine and smoked meat as soon as they get into Canada?
Jackman and Stewart were great in their roles, and in their scenes together. They had a fantastic father-son vibe going, and while it was painful to see them in their final days, there were certainly some dark comedic elements, like Logan checking that Xavier took his pills, and Xavier sticking his tongue out like a kid. Our parents become our children, and they did a great job of showing that. It was touching.
Speaking of dark comedy,Stephen Merchant as Caliban was inspiring. I really liked his character, and I would have preferred to see him more, to the point that I would have rather the road trip be about Logan, Xavier and Caliban instead of Laura.
Laura... and the rest of the kids... I just didn't care about them. Maybe they made her too feral. She might have worked better if she had more innocence to protect, that way it would have seemed awful to see her resort to violence. Laura would have also worked better as a boy, and as a son for Logan, to serve as a counterbalance for the father-son relationship between Xavier and Logan.
The rest of the kids seemed little more than a plot device. They were a weak point in the movie and a distraction, and I think they could have been skipped altogether.
Bad guys? Pierce was OK. Better than OK, but not really great. The mad scientist, Dr. Rice, was as generic as they come, and it might have been better to combine his character with Pierce's. It might have also been better if they gave him some moral standing, to give the movie some shades of grey.
The fight scenes were brutal. Really, really brutal. X-24 was beaten a too easily. If "Logan" wasn't an action movie, I'd say it would have been appropriate, but Logan is an action movie.
TL;DR: Great performances by the adults, kids were annoying, story was ok, still a good movie because of the leads.